Skip to content

RTBHouse: Extract tagid from Imp fields #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pjaworski-rtbh wants to merge 3 commits into
base: master
Choose a base branch
from
Open

RTBHouse: Extract tagid from Imp fields #4624

pjaworski-rtbh wants to merge 3 commits into from

Conversation

@pjaworski-rtbh
Copy link
Contributor

@pjaworski-rtbh pjaworski-rtbh commented Dec 3, 2025 •
edited
Loading

🔧 Type of changes

  • bid adapter update
  • enhancement

✨ What's the context?

Related PR (Java): prebid/prebid-server-java#4306
RTBHouse bidder was not setting imp.tagid in outgoing requests, which could impact ad targeting effectiveness. This change adds support for populating tagid from various incoming request fields with a defined priority order.

📋 Description

Adds logic to set imp.tagid in RTBHouse bid requests using fallback priority: imp.ext.gpid → imp.ext.data.adserver.adslot → imp.ext.data.pbadslot → imp.id → null. This ensures better ad targeting by providing RTBHouse with appropriate tagid values.

🧪 Testing results

Tests run: 34, Failures: 0, Errors: 0, Skipped: 0
coverage: 92.6% of statements
All RTBHouse bidder tests pass successfully. Updates:

  • New exemplary tests for the feature (4 tests)
  • Updated existing 17 exemplary and 9 supplemental tests to include imp.tagid in expected outgoing requests

Other information

Please reach us at [email protected] with [email protected] and cc [email protected].

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, a29a2da

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		86.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:165:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:218:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:226:	getTagIDFromImpExt	91.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:255:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:291:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:358:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:369:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:389:	resolveMacros		100.0%
total:									(statements)		91.6%

@pjaworski-rtbh pjaworski-rtbh marked this pull request as ready for review December 3, 2025 13:21
@pjaworski-rtbh pjaworski-rtbh mentioned this pull request Dec 3, 2025
Merged
2 tasks
@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 94f705b

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:40:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:48:	MakeRequests		88.9%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:161:	setPublisherID		90.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:214:	clearAuctionEnvironment	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:221:	getTagIDFromImpExt	91.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:250:	getImpressionExt	85.7%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:286:	MakeBids		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:353:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:364:	getNativeAdm		100.0%
github.com/prebid/prebid-server/v3/adapters/rtbhouse/rtbhouse.go:384:	resolveMacros		100.0%
total:									(statements)		92.6%

@bsardo bsardo added the adapter label Dec 3, 2025
@pjaworski-rtbh
Copy link
Contributor Author

pjaworski-rtbh commented Jan 9, 2026

@bsardo Could you please share an estimate for when we can expect an updated status on this PR? The Java PR is nearly finalized, and we’d like to bring this one to the same point as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bsardo bsardo

@pm-jaydeep-mohite pm-jaydeep-mohite

Labels

adapter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pjaworski-rtbh @bsardo @pm-jaydeep-mohite